Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the integration tests for the cart module #3023

Closed
1 of 6 tasks
pkarw opened this issue Jun 6, 2019 · 1 comment
Closed
1 of 6 tasks

Upgrade the integration tests for the cart module #3023

pkarw opened this issue Jun 6, 2019 · 1 comment
Assignees
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P2: Important Priority mark - still high ;)
Milestone

Comments

@pkarw
Copy link
Collaborator

pkarw commented Jun 6, 2019

What is the motivation for adding / enhancing this feature?

After the #2887 the cart module got refactored, we need to update our unit tests to cover all the new interfaces

What are the acceptance criteria

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

@pkarw pkarw added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P2: Important Priority mark - still high ;) 3: Medium complexity labels Jun 6, 2019
@sandermangel sandermangel added this to Accepted Feature Requests in Issue Kanban Sep 6, 2019
@pkarw pkarw assigned andrzejewsky and unassigned lukeromanowicz Sep 12, 2019
@pkarw
Copy link
Collaborator Author

pkarw commented Sep 12, 2019

@andrzejewsky Patryk, before you'll start the checkout refactor let's have cart tests finished - we're after all these refactorings so it would be great to finish that one first

@patzick patzick added this to the 1.11.0-rc.1 milestone Sep 23, 2019
@patzick patzick closed this as completed Sep 23, 2019
Issue Kanban automation moved this from Accepted Feature Requests to Done Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P2: Important Priority mark - still high ;)
Projects
No open projects
Issue Kanban
  
Done
Development

No branches or pull requests

4 participants