Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with footer pages for non-default stores. #3579

Closed
1 of 5 tasks
alinadivante opened this issue Sep 18, 2019 · 3 comments
Closed
1 of 5 tasks

Problem with footer pages for non-default stores. #3579

alinadivante opened this issue Sep 18, 2019 · 3 comments
Assignees
Labels
bug Bug reports P2: Important Priority mark - still high ;) QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@alinadivante
Copy link
Collaborator

Current behavior

Links from footer (in non-default stores) redirect to pages without content, and CMS pages to 404 page not found.
When I open CMS page from the footer, the following error occurs in dev console:
image
And if I open CMS via URL, the following error occurs in dev console:
image

Expected behavior

All links should work properly, without errors in dev console.

Steps to reproduce the issue

  1. Run the latest develop version with mulistore
  2. Go to /de or /it store
  3. Check links from footer
  4. Open CMS pages from footer
  5. Open CMS via link, e.g http://localhost:3000/de/i/about-us

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label Sep 18, 2019
@alinadivante alinadivante added this to the 1.11.0-rc.1 milestone Sep 18, 2019
@pkarw
Copy link
Collaborator

pkarw commented Sep 18, 2019

Seemingly these cms pages were not synced for lang. versions; which is fine and we should probably just better handle the 404 error (not having hydration/console errors); then to remove the links from footer if the currentStoreView().storeCode !== config.i18n.defaultStorecode

@pkarw pkarw added the P2: Important Priority mark - still high ;) label Sep 18, 2019
@andrzejewsky
Copy link
Contributor

@alinadivante works for me, can you check again with the newest develop (maybe It has been fixed)?

@alinadivante
Copy link
Collaborator Author

@andrzejewsky I still have the same errors, so maybe I'll send you my config and then check again if the problem is also reproducible for you

@alinadivante alinadivante mentioned this issue Sep 20, 2019
6 tasks
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Sep 25, 2019
@patzick patzick closed this as completed Sep 25, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports P2: Important Priority mark - still high ;) QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

4 participants