Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The same country is displayed twice in the country switcher. #3587

Closed
5 tasks
alinadivante opened this issue Sep 20, 2019 · 3 comments
Closed
5 tasks

The same country is displayed twice in the country switcher. #3587

alinadivante opened this issue Sep 20, 2019 · 3 comments
Assignees
Labels
bug Bug reports P3: Normal Priority mark - normal priority QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@alinadivante
Copy link
Collaborator

alinadivante commented Sep 20, 2019

Current behavior

If you are in store other than the default store, you will see that the same country is displayed twice in the country switching module.

image
(but url addresses are fine)

Expected behavior

There should be three different country names:

  • United States - English
  • Germany - German
  • Italy - Italian

Steps to reproduce the issue

  1. Go to non-default store, e.g. http://localhost:3000/de
  2. Scroll down the page
  3. Press "country switcher"

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label Sep 20, 2019
@pkarw pkarw added the P3: Normal Priority mark - normal priority label Sep 20, 2019
@andrzejewsky
Copy link
Contributor

Unfortunately I'm unable to display all languages. Anyone know if there is some possibility to have access for all of available languages including default one?

@pkarw
Copy link
Collaborator

pkarw commented Sep 20, 2019

@andrzejewsky
Copy link
Contributor

@pkarw yeah, and this line displays current language but... when I have set "German" how can I display default one ("English")? There is no way to read the default lang. The config.i18n.* contains always current one.

@patzick patzick added this to the 1.11.0-rc.1 milestone Sep 21, 2019
@pkarw pkarw closed this as completed Sep 24, 2019
@alinadivante alinadivante added the QA approved after merge Testers will add this label after positive check on merged changes label Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports P3: Normal Priority mark - normal priority QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

4 participants