Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect size of suggested product pictures, in some scenarios #3590

Closed
2 of 5 tasks
ArturDivante opened this issue Sep 20, 2019 · 1 comment
Closed
2 of 5 tasks
Assignees
Labels
1: Easy bug Bug reports P2: Important Priority mark - still high ;) QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@ArturDivante
Copy link
Collaborator

ArturDivante commented Sep 20, 2019

In some scenarios, when availible products pool is limited, suggested product pictures are displayed in incorrectly small size.

Steps to reproduce the issue

  1. Launch develop with multistore enabled
    (reproducing this issue is easier on mulistore, because product pool is smaller and therefore it's easier to find product with only 2 or 3 suggested / promoted options instead of full 8)
  2. Open:
    http://localhost:3000/de/women/tops-women/jackets-women/jackets-23/riona-full-zip-jacket-1289.html?childSku=WJ05-XS-Brown
    or
    http://localhost:3000/de/women/tops-women/hoodies-and-sweatshirts-women/hoodies-and-sweatshirts-24/selene-yoga-hoodie-1113.html?childSku=WH05-XS-Orange
  3. Browse product page to suggested products section

Current behavior

  1. Pictures are displayed in incorrect size
    KingSize01
    kingSize02

2. Also: In such cases, one of the suggested products is the current product itself

Expected behavior

  1. Suggested products are displayed correctly
  2. Also: currently open product should not be among suggested or similar products

Repository

develop

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chrome
  • OS: Win10, Ubuntu 18.04
  • Code Version: develop with multistore enabled

Additional information

Problem don't seem to be directly related to the multistore, but it's easier to reproduce there because of limited number of products in some categories.
When we click on a product with 8 suggestions, they are displayed correctly. Problem occurs only when opened product has less available suggestions.

@ArturDivante ArturDivante added the bug Bug reports label Sep 20, 2019
@pkarw pkarw added 1: Easy P2: Important Priority mark - still high ;) labels Sep 20, 2019
@pkarw pkarw added this to the 1.11.0-rc.1 milestone Sep 20, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Sep 21, 2019
@patzick patzick closed this as completed Sep 21, 2019
@ArturDivante ArturDivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Sep 23, 2019
@ArturDivante
Copy link
Collaborator Author

Problem fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports P2: Important Priority mark - still high ;) QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

4 participants