fix(VCheckbox): add missing input classes

wasn't properly applying disabled or focused styles fixes #7509
vuetifyjs · Jun 14, 2019 · b64dafc · b64dafc
1 parent 303d3c3
commit b64dafc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/vuetify/src/components/VCheckbox/VCheckbox.ts b/packages/vuetify/src/components/VCheckbox/VCheckbox.ts
@@ -3,6 +3,7 @@ import '../../styles/components/_selection-controls.sass'
 
 // Components
 import VIcon from '../VIcon'
+import VInput from '../VInput'
 
 // Mixins
 import Selectable from '../../mixins/selectable'
@@ -36,6 +37,7 @@ export default Selectable.extend({
   computed: {
     classes (): object {
       return {
+        ...VInput.options.computed.classes.call(this),
         'v-input--selection-controls': true,
         'v-input--checkbox': true,
       }

diff --git a/packages/vuetify/src/components/VCheckbox/__tests__/__snapshots__/VCheckbox.spec.ts.snap b/packages/vuetify/src/components/VCheckbox/__tests__/__snapshots__/VCheckbox.spec.ts.snap
@@ -13,7 +13,7 @@ exports[`VCheckbox.ts should be disabled 1`] = `
 
 exports[`VCheckbox.ts should render themed component 1`] = `
 
-<div class="v-input v-input--selection-controls v-input--checkbox">
+<div class="v-input theme--light v-input--selection-controls v-input--checkbox">
   <div class="v-input__control">
     <div class="v-input__slot">
       <div class="v-input--selection-controls__input">
@@ -45,7 +45,7 @@ exports[`VCheckbox.ts should render themed component 1`] = `
 
 exports[`VCheckbox.ts should use custom icons 1`] = `
 
-<div class="v-input v-input--selection-controls v-input--checkbox">
+<div class="v-input theme--light v-input--selection-controls v-input--checkbox">
   <div class="v-input__control">
     <div class="v-input__slot">
       <div class="v-input--selection-controls__input">
@@ -77,7 +77,7 @@ exports[`VCheckbox.ts should use custom icons 1`] = `
 
 exports[`VCheckbox.ts should use custom icons 2`] = `
 
-<div class="v-input v-input--selection-controls v-input--checkbox">
+<div class="v-input theme--light v-input--selection-controls v-input--checkbox">
   <div class="v-input__control">
     <div class="v-input__slot">
       <div class="v-input--selection-controls__input">
@@ -109,7 +109,7 @@ exports[`VCheckbox.ts should use custom icons 2`] = `
 
 exports[`VCheckbox.ts should use custom icons 3`] = `
 
-<div class="v-input v-input--selection-controls v-input--checkbox">
+<div class="v-input v-input--is-label-active v-input--is-dirty theme--light v-input--selection-controls v-input--checkbox">
   <div class="v-input__control">
     <div class="v-input__slot">
       <div class="v-input--selection-controls__input">