-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VTextField/VSelect): don't focus clear icon if dirty #10461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekkarczmarczyk
added
the
T: bug
Functionality that does not work as intended/expected
label
Feb 5, 2020
johnleider
force-pushed
the
fix/dont-render-clear-icon-if-not-dirty
branch
from
February 5, 2020 06:16
dddf69b
to
a2dc27f
Compare
johnleider
changed the title
fix(VInput): don't render clear icon if not dirty
fix(VTextField/VSelect): don't focus clear icon if dirty
Feb 5, 2020
KaelWD
reviewed
Feb 5, 2020
@@ -419,7 +419,9 @@ export default baseMixins.extend<options>().extend({ | |||
|
|||
icon.children![0].data = mergeData(icon.children![0].data!, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole thing was a mistake anyway, it should only apply to the default append icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KaelWD
reviewed
Feb 5, 2020
packages/vuetify/src/components/VFileInput/__tests__/__snapshots__/VFileInput.spec.ts.snap
Outdated
Show resolved
Hide resolved
KaelWD
force-pushed
the
master
branch
3 times, most recently
from
February 5, 2020 07:02
49b9532
to
9e00958
Compare
johnleider
reviewed
Feb 5, 2020
also resolved v-select clear selection
Co-Authored-By: John Leider <john@vuetifyjs.com>
johnleider
force-pushed
the
fix/dont-render-clear-icon-if-not-dirty
branch
from
February 5, 2020 18:04
18b0c45
to
5136617
Compare
needed to override color helper classes
johnleider
approved these changes
Feb 5, 2020
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
C: VSelect
VSelect
C: VTextField
VTextField
T: bug
Functionality that does not work as intended/expected
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
jest, playground
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).