Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTextField/VSelect): don't focus clear icon if dirty #10461

Merged
merged 6 commits into from
Feb 5, 2020

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Feb 5, 2020

How Has This Been Tested?

jest, playground

Markup:

<template>
  <v-container>
    <v-file-input />
    <v-text-field />
    <v-text-field clearable />
    <v-select :items="['foo']" clearable />
    <v-autocomplete :items="['foo']" clearable />
    <v-combobox :items="['foo']" clearable />
  </v-container>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Feb 5, 2020
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Feb 5, 2020
@johnleider johnleider force-pushed the fix/dont-render-clear-icon-if-not-dirty branch from dddf69b to a2dc27f Compare February 5, 2020 06:16
@johnleider johnleider changed the title fix(VInput): don't render clear icon if not dirty fix(VTextField/VSelect): don't focus clear icon if dirty Feb 5, 2020
@jacekkarczmarczyk jacekkarczmarczyk removed their assignment Feb 5, 2020
@@ -419,7 +419,9 @@ export default baseMixins.extend<options>().extend({

icon.children![0].data = mergeData(icon.children![0].data!, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole thing was a mistake anyway, it should only apply to the default append icon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaelWD KaelWD force-pushed the master branch 3 times, most recently from 49b9532 to 9e00958 Compare February 5, 2020 07:02
@johnleider johnleider force-pushed the fix/dont-render-clear-icon-if-not-dirty branch from 18b0c45 to 5136617 Compare February 5, 2020 18:04
@johnleider johnleider added this to the v2.2.x milestone Feb 5, 2020
@johnleider johnleider added C: VSelect VSelect C: VTextField VTextField labels Feb 5, 2020
@johnleider johnleider merged commit cc7386b into master Feb 5, 2020
@johnleider johnleider deleted the fix/dont-render-clear-icon-if-not-dirty branch February 5, 2020 20:00
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VSelect VSelect C: VTextField VTextField T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants