Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCalendar): event ends midnight (#11159) #11168

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

ClickerMonkey
Copy link
Contributor

@ClickerMonkey ClickerMonkey commented Apr 21, 2020

fixes #11159

If a timed event in a day view ended at midnight, it showed up on the next day as an event.

Description

resolves #11159

Motivation and Context

How Has This Been Tested?

visually, unit

Markup:

Before the fix Weekly Meeting 1 & 3 would display on the next day.

<template>
  <v-container>
    <v-calendar
      ref="calendar"
      :now="today"
      :value="today"
      :events="events"
      color="primary"
      type="week"
    ></v-calendar>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
      today: '2019-01-08',
      events: [
        {
          name: 'Weekly Meeting 1',
          start: '2019-01-06 23:00',
          end: '2019-01-07 00:00',
        },
        {
          name: 'Weekly Meeting 2',
          start: '2019-01-06 23:00',
          end: '2019-01-07 00:15',
        },
        {
          name: 'Weekly Meeting 3',
          start: '2019-01-05 23:00',
          end: '2019-01-06 00:00',
        },
        {
          name: 'Weekly Meeting 4',
          start: '2019-01-05 23:00',
          end: '2019-01-06 00:15',
        },
        {
          name: 'Weekly Meeting 5',
          start: '2019-01-05',
          end: '2019-01-06',
        },
        {
          name: 'Weekly Meeting 6',
          start: '2019-01-06',
          end: '2019-01-07',
        },
      ],
    }),
    mounted () {
      this.$refs.calendar.scrollToTime('08:00')
    },
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@ClickerMonkey ClickerMonkey added the C: VCalendar VCalendar label Apr 21, 2020
@ClickerMonkey ClickerMonkey self-assigned this Apr 21, 2020
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Apr 21, 2020
@johnleider johnleider added this to the v2.2.x milestone Apr 21, 2020
@johnleider johnleider merged commit ab86223 into master Apr 21, 2020
@johnleider johnleider deleted the fix/11159-calendar-event-end branch April 21, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCalendar VCalendar T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Calendar events end time 00:00 showing wrong values
2 participants