Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VTextField): Update value on compositionend #11194

Merged
merged 2 commits into from Apr 24, 2020
Merged

fix(VTextField): Update value on compositionend #11194

merged 2 commits into from Apr 24, 2020

Conversation

kouqon
Copy link
Contributor

@kouqon kouqon commented Apr 23, 2020

See #5748
fixes #11190

Description

Motivation and Context

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added this to the v2.2.x milestone Apr 24, 2020
@johnleider johnleider force-pushed the fix/#11190-vtextfield-update-value-oncompositionend branch from b4151d7 to df15fc1 Compare April 24, 2020 15:48
@johnleider johnleider merged commit f51bef6 into vuetifyjs:master Apr 24, 2020
@WIStudent WIStudent mentioned this pull request Apr 27, 2020
Closed
kouqon pushed a commit to kouqon/vuetify that referenced this pull request Apr 30, 2020
revert: fix(VTextField): update value on compositionend (vuetifyjs#11194
7c50d52 
)

This reverts commit f51bef6.

fixes vuetifyjs#11243
johnleider pushed a commit that referenced this pull request Apr 30, 2020
@kouqon
revert(VTextField): v-model behavior on IME composing (#11274)
5f82fe2 
fixes #11243

* revert: fix(VTextField): update value on compositionend (#11194)

This reverts commit f51bef6.

* revert: fix(VTextField): Skip value property update if IME composing string (#11134)

This reverts commit c02be82.

Co-authored-by: k_kondou00 <k_kondou00@shimadzu-techno.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnleider johnleider johnleider approved these changes

Assignees

@kouqon kouqon

Labels
C: VTextField VTextField
Projects
None yet
Milestone
v2.2.x
Development

Successfully merging this pull request may close these issues.

[Bug Report] input IME composing string in Chrome not reflected
3 participants
@kouqon @johnleider @jacekkarczmarczyk