Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-edit-dialog broken #1169

Closed
smxsm opened this issue Jul 28, 2017 · 4 comments
Closed

v-edit-dialog broken #1169

smxsm opened this issue Jul 28, 2017 · 4 comments
Assignees
Labels
T: bug Functionality that does not work as intended/expected

Comments

@smxsm
Copy link

smxsm commented Jul 28, 2017

Steps to reproduce

Just go to the official documentation and try the datatable component with inline text editing.
Edit a value in the "#5 Search with custom page text" example data table and try to save it.

Versions

Vue 2.4.2, VuetifyJS v.0.14.7 on Chrome Browser Version 60.0.3112.78, Mac OS

What is expected ?

I expect changed values to be updated correctly.

What is actually happening ?

After editing a value, the field says "isTrusted: true" in JSON format, the user input is lost, and the field can't be saved since the value is invalid.

image

Reproduction Link

See here: https://vuetifyjs.com/components/data-tables

@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Jul 28, 2017
@johnleider
Copy link
Member

With the new listeners from vue@2.4 this example needed to be updated.

@smxsm
Copy link
Author

smxsm commented Jul 29, 2017

Hi, not sure that's enough, if I change that I get:

TypeError: Cannot read property 'value' of undefined

Here is my changed line:

v-on:change="e => props.item.externalId = e.target.value"

Running on Vue 2.4.2 and Vuetify 0.14.7.

The weird thing is, if I print the "e" object on the console, it surely has a "target" object and that has the correct "value" ... and if I check for "e.target" before setting the field, everything seems to work... any idea?

v-on:change="e => e.target ? props.item.externalId = e.target.value : ''"

@vuras
Copy link

vuras commented Aug 7, 2017

I have stumbled upon the same issue as smxsm. Getting

TypeError: Cannot read property 'value' of undefined

@johnleider johnleider added the pending review The issue is still pending disposition label Aug 7, 2017
@johnleider johnleider self-assigned this Aug 7, 2017
@johnleider johnleider reopened this Aug 7, 2017
@johnleider johnleider removed the pending review The issue is still pending disposition label Aug 10, 2017
@lock
Copy link

lock bot commented Apr 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

3 participants