Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VFileInput): avoid input field event capturing in safari #11897

Merged
merged 1 commit into from Sep 29, 2020

Conversation

ahocevar
Copy link
Contributor

Description

This pull request avoids that the native input[type="file"] field receives events when clicking on the input part of v-file-input.

Fixes #10832.

Motivation and Context

With this change, v-file-input works as expected in Safari, as described in #10832.

How Has This Been Tested?

I tested the change locally with the code provided in https://codepen.io/anon/pen/RXaPOX?&editable=true&editors=101.

Markup:

<div id="app">
  <v-app id="inspire">
    <v-file-input label="File input"></v-file-input>
  </v-app>
</div>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@ahocevar ahocevar changed the title Fix for input field capturing events in v-file-input in Safari fix(VFileInput): avoid input field event capturing in Safari Jul 20, 2020
@KaelWD KaelWD force-pushed the master branch 4 times, most recently from 902f181 to a45560a Compare July 23, 2020 14:39
@ahocevar
Copy link
Contributor Author

Since this has not gotten any attention for 6 weeks, can someone please give me guidance on what else would have to be done on my end to get this reviewed? Thanks in advance.

@TPXP
Copy link

TPXP commented Sep 29, 2020

Thank you so much for digging into this, you made my day!

@johnleider
Copy link
Member

Not intentionally ignored. My focus was on the new documentation.

@johnleider johnleider self-requested a review September 29, 2020 18:54
@johnleider johnleider added C: VFileInput T: bug Functionality that does not work as intended/expected labels Sep 29, 2020
@johnleider johnleider added this to the v2.3.x milestone Sep 29, 2020
@johnleider johnleider added the platform specific The issue only occurs on a specific platform label Sep 29, 2020
@johnleider johnleider changed the title fix(VFileInput): avoid input field event capturing in Safari fix(VFileInput): avoid input field event capturing in safari Sep 29, 2020
@johnleider johnleider merged commit d5800aa into vuetifyjs:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VFileInput platform specific The issue only occurs on a specific platform T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] VFileInput does not work with Safari on MacOS or iOS When click on placeholder or label text
3 participants