Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default background color for dark themed lists #1222

Closed
DedDorito opened this issue Aug 2, 2017 · 2 comments
Closed

Change default background color for dark themed lists #1222

DedDorito opened this issue Aug 2, 2017 · 2 comments
Labels
T: bug Functionality that does not work as intended/expected

Comments

@DedDorito
Copy link

DedDorito commented Aug 2, 2017

Steps to reproduce

Use a v-list element with the dark attribute.

Versions

Latest of everything.

What is expected ?

According to the MD spec regarding dark themes, the default background color of the v-list element when used with the dark attribute should be #303030.

https://material.io/guidelines/style/color.html#color-themes

If users want to keep the current behavior (i.e. lists appear lighter than the background), they should wrap their lists in a card. This seems to be closer to the intention outlined in the MD spec, but let me know if you disagree with my interpretation.

What is actually happening ?

The background color is #424242, which makes lists appear lighter and not flush with a page when used with the dark attribute.

Reproduction Link

https://codepen.io/anon/pen/YxGGxY

Side Note

The navigation drawer seems to suffer from this problem as well, although it's not quite as clear cut to me. I believe it should also default to #303030, but I can open a separate issue for that one if deemed to be worthy of a conversation.

Fix

.application--dark
  & .list,
  & .navigation-drawer
    background: #303030
@johnleider johnleider added pending review The issue is still pending disposition T: bug Functionality that does not work as intended/expected and removed pending review The issue is still pending disposition labels Aug 3, 2017
@johnleider
Copy link
Member

No idea why I changed this.

@lock
Copy link

lock bot commented Apr 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

2 participants