You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using a length that is not an int number, the v-pagination component does not disable the "next page" button, and allows the user to move forward infinitely.
Of course, any non integer length is silly, but a careless dev (me) could create a pagination with :length.number="total/pageSize" and forget to Math.ceil/round...
The behavior changes when
lenght < 6
length >6 && length < 7
length > 7
A side effect of this, is that the float number overflows the button because of rounding errors, but I'm guessing this won't be a problem once the floats are handled. (It seems to be working fine for relatively large int numbers)
Steps to reproduce
Create a v-pagination with a :length.number=<float> (6.4 for extra weirdness)
Versions
Vuetify 0.14.8, chrome 59 on W10
What is expected ?
Length should be rounded up. or maybe throw an error (I guess that rounding is better, because it is less frustrating for the dev)
What is actually happening ?
if length <6: As the page increments by 1, you never reach the highest number
if length > 6 && < 7: buttons show float labels, that increment by 1
if length > 7: the first buttons are ok, the last button shows the number as float
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord
lockbot
locked as resolved and limited conversation to collaborators
Apr 16, 2019
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
T: enhancementFunctionality that enhances existing features
When using a
length
that is not an int number, thev-pagination
component does not disable the "next page" button, and allows the user to move forward infinitely.Of course, any non integer length is silly, but a careless dev (me) could create a
pagination
with:length.number="total/pageSize"
and forget toMath.ceil/round
...The behavior changes when
lenght < 6
length >6 && length < 7
length > 7
A side effect of this, is that the float number overflows the button because of rounding errors, but I'm guessing this won't be a problem once the floats are handled. (It seems to be working fine for relatively large int numbers)
Steps to reproduce
Create a
v-pagination
with a:length.number=<float>
(6.4 for extra weirdness)Versions
Vuetify 0.14.8, chrome 59 on W10
What is expected ?
Length should be rounded up. or maybe throw an error (I guess that rounding is better, because it is less frustrating for the dev)
What is actually happening ?
length <6
: As the page increments by1
, you never reach the highest numberlength > 6 && < 7
: buttons showfloat
labels, that increment by1
length > 7
: the first buttons are ok, the last button shows the number asfloat
Reproduction Link
https://codepen.io/anon/pen/OjboNO
The text was updated successfully, but these errors were encountered: