Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Font Awesome preset comments #12522

Open
megaroeny opened this issue Oct 28, 2020 · 0 comments
Open

[Documentation] Font Awesome preset comments #12522

megaroeny opened this issue Oct 28, 2020 · 0 comments
Assignees
@MajesticPotatoe
Labels
Service: Icons T: enhancement Functionality that enhances existing features

Comments

@megaroeny
Copy link

Problem to solve

Clarity in icon usage for components, for delete and clear. Currently, it's confusing for people that use Font Awesome (5).

Proposed solution

Update comments in the fa.ts file, so it's more clear which components the icons are used in by default. Maybe include cancel and close too since those words all mean similar things.

image
@johnleider johnleider added this to the v2.3.x milestone Dec 3, 2020
@johnleider johnleider added T: enhancement Functionality that enhances existing features and removed T: documentation labels Dec 3, 2020
@KaelWD KaelWD modified the milestones: v2.3.x, v2.4.x Dec 23, 2020
@KaelWD KaelWD modified the milestones: v2.4.x, v2.5.x May 11, 2021
@johnleider johnleider removed this from the v2.5.x milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajesticPotatoe MajesticPotatoe

Labels
Service: Icons T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@megaroeny @johnleider @jacekkarczmarczyk @KaelWD @MajesticPotatoe