Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-text-fields are not styled when used in a v-data-table footer slot #1295

Closed
robokozo opened this issue Aug 9, 2017 · 2 comments
Closed

Comments

@robokozo
Copy link

robokozo commented Aug 9, 2017

Steps to reproduce

Create a v-data-table
Add footer slot
Have footer cell contain a v-text-field

Versions

Vue.js v2.4.2
Vuetify v0.14.8
Chrome v59.0.3071.115
Firefox v54.0.1

What is expected ?

I would expect the inputs within the tfoot to appear in the same consistent way across various components.

What is actually happening ?

The input fields are missing the the underline. It does not appear correctly when the cursor is within the input element either.

Reproduction Link

https://jsfiddle.net/tgpfhn8m/

@jacekkarczmarczyk
Copy link
Member

jacekkarczmarczyk commented Aug 9, 2017

There's a following rule that changes the styling of the input:

.datatable tfoot .input-group__details {
    display: none;
}

Not sure why it's there, but for now you can try to override it in you css

EDIT: Actually I think that inputs that are added by datatable component (text fields in footer, checkboxes for selecting rows) should have additional class describing what kind of input it is (.checkbox--table-row or similar) and their styling should be done by adding rules to this particular class instead of using selectors like in the rule above.
It will allow devs to easly use the default styling as well as special styling designed for special cases, it will be also more "BEM-like"

@lock
Copy link

lock bot commented Apr 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants