Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSelect): make CSS order-independent #13150

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

haggys22
Copy link
Contributor

Description

Fix #13149

Motivation and Context

#13149

How Has This Been Tested?

visually

Markup:

<v-app>
  <v-container>
    <v-row>
      <v-col>
        <v-text-field
            label="v-text-field"
            filled
        ></v-text-field>
      </v-col>  
      <v-col>
        <v-select
            label="v-select"
            filled
        ></v-select>
      </v-col>  
      <v-col>
        <v-autocomplete
            label="v-autocomplete"
            filled
        ></v-autocomplete>
      </v-col>  
    </v-row>
  </v-container>
</v-app>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added C: VSelect VSelect T: bug Functionality that does not work as intended/expected labels Mar 16, 2021
@johnleider johnleider added this to the v2.4.x milestone Mar 16, 2021
@johnleider johnleider requested a review from KaelWD March 16, 2021 00:44
@KaelWD KaelWD changed the title fix(VSelect): make VSelect CSS order-independent fix(VSelect): make CSS order-independent Mar 23, 2021
@KaelWD KaelWD merged commit d285435 into vuetifyjs:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] VSelect (filled, with label) input margin-top depends on Webpack CSS output order
3 participants