Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VIcon): add color prop #13251

Merged
merged 2 commits into from
Mar 15, 2021
Merged

feat(VIcon): add color prop #13251

merged 2 commits into from
Mar 15, 2021

Conversation

nekosaur
Copy link
Member

Description

add color prop

Motivation and Context

How Has This Been Tested?

playground and unit test

Markup:

<template>
  <v-app>
    <v-icon color="primary" icon="$close" />
    <v-icon color="#ff00ff" icon="svg:M21,7L9,19L3.5,13.5L4.91,12.09L9,16.17L19.59,5.59L21,7Z" />
  </v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added this to In progress in Vuetify 3 - Titan via automation Mar 15, 2021
@johnleider johnleider added this to the v3.0.0 milestone Mar 15, 2021
Vuetify 3 - Titan automation moved this from In progress to Reviewer approved Mar 15, 2021
@johnleider johnleider merged commit edc2db9 into next Mar 15, 2021
Vuetify 3 - Titan automation moved this from Reviewer approved to Done Mar 15, 2021
@johnleider johnleider deleted the feat/icon-color branch March 15, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants