-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change generic color class names #13254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my one question, looks good to me.
colors: { | ||
primary: colors.red.darken1, // #E53935 | ||
secondary: colors.red.lighten4, // #FFCDD2 | ||
accent: colors.indigo.base, // #3F51B5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still use accent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. What is our stance on the global .v-application class? I believe we talked about removing it.
I think it would make sense to make them global, since that's how the theme classes work |
@KaelWD could you chime in? |
Everything should be global in v3 |
Description
Motivation and Context
This aligns generic color classes with those generated from the theme system, which means that the generic ones can be used in
color
prop without any additional work.This is a breaking change.
How Has This Been Tested?
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).