Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change generic color class names #13254

Merged
merged 4 commits into from
Mar 18, 2021
Merged

feat: change generic color class names #13254

merged 4 commits into from
Mar 18, 2021

Conversation

nekosaur
Copy link
Member

@nekosaur nekosaur commented Mar 11, 2021

Description

// v2
.indigo
.indigo--text

.indigo.lighten-2
.indigo--text.text--darken-1

// v3
.bg-indigo
.text-indigo

.bg-indigo-lighten-2
.text-indigo-darken-1

Motivation and Context

This aligns generic color classes with those generated from the theme system, which means that the generic ones can be used in color prop without any additional work.

This is a breaking change.

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my one question, looks good to me.

colors: {
primary: colors.red.darken1, // #E53935
secondary: colors.red.lighten4, // #FFCDD2
accent: colors.indigo.base, // #3F51B5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still use accent?

@johnleider johnleider added this to In progress in Vuetify 3 - Titan via automation Mar 15, 2021
@johnleider johnleider added this to the v3.0.0 milestone Mar 15, 2021
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. What is our stance on the global .v-application class? I believe we talked about removing it.

@nekosaur
Copy link
Member Author

I think it would make sense to make them global, since that's how the theme classes work

@johnleider
Copy link
Member

I think it would make sense to make them global, since that's how the theme classes work

@KaelWD could you chime in?

@KaelWD
Copy link
Member

KaelWD commented Mar 17, 2021

Everything should be global in v3

@nekosaur nekosaur added the semver: major Contains breaking API changes label Mar 18, 2021
@nekosaur nekosaur merged commit 35bcdba into next Mar 18, 2021
Vuetify 3 - Titan automation moved this from In progress to Done Mar 18, 2021
@nekosaur nekosaur deleted the feat/color-classes branch March 18, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: major Contains breaking API changes
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants