-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VBadge): port to v3 #13277
feat(VBadge): port to v3 #13277
Conversation
83e4d02
to
8cd727e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scss/sass imports should match v-banner, v-btn, etc
opting to use a boolean true based prop, updated tests
302d229
to
72da15f
Compare
72da15f
to
9db026d
Compare
Requesting Initial comments from @vuetifyjs/contributors @vuetifyjs/core-team |
Requesting Final comments from @vuetifyjs/core-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
packages/vuetify/src/components/VBadge/__tests__/VBadge.spec.tsx
Outdated
Show resolved
Hide resolved
packages/vuetify/src/components/VBadge/__tests__/VBadge.spec.tsx
Outdated
Show resolved
Hide resolved
Haven't actually tried the code yet |
Co-authored-by: Albert Kaaman <albert@kaaman.nu>
Description
Updated v-badge for v3
Breaking changes
Changedoverlap
default value totrue
. In my opinion this looks better for most use cases.overlap
prop and made default. For existing style, use thefloating
propavatar
propleft
prop, uselocation
insteadbottom
prop, uselocation
insteadmode
prop, usetransition
insteadorigin
prop, usetransition
insteadoffset-x
andoffset-y
now offset the original positioning as their name implies instead of absolutely positioning the badgetile
is removed (removal inherited from border-radius composable)value
is nowmodel-value
Motivation and Context
How Has This Been Tested?
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).