fix(VBadge): add missing !default on border radius #13296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable $badge-dot-border-radius was missing a !default
misterupkeep
added a commit
to bonfire-xmpp/bonfire
that referenced
this pull request
Mar 19, 2021
Readds changes made in dac06f5, but broken in 59e8f5e (most likely). Badge border radius is an interim fix while waiting for vuetifyjs/vuetify#13296
KaelWD
approved these changes
Mar 23, 2021
KaelWD
added
C: VBadge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Variable
$badge-dot-border-radiuswas missing a!defaultMotivation and Context
Changing the border radius on badge dots was impossible without a CSS selector and
!importantTypes of changes
Checklist:
masterfor bug fixes and documentation updates,devfor new features and backwards compatible changes andnextfor non-backwards compatible changes).I've added relevant changes to the documentation (applies to new features and breaking changes in core library)