-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(display): port to v3 #13318
Merged
Merged
feat(display): port to v3 #13318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekosaur
reviewed
Mar 26, 2021
As mentioned on Discord, Window.matchMedia() might be something to consider, depending on your needs. |
I think this might be best served in the theme composable where it's context makes a little more sense. |
johnleider
force-pushed
the
feat/v3-display
branch
from
April 16, 2021 22:21
ceea37c
to
4cc87b9
Compare
johnleider
force-pushed
the
feat/v3-display
branch
from
April 17, 2021 00:14
4cc87b9
to
f0017f7
Compare
Requesting Initial comments from @vuetifyjs/core-team |
nekosaur
reviewed
Apr 18, 2021
packages/vuetify/src/components/VNavigationDrawer/VNavigationDrawer.tsx
Outdated
Show resolved
Hide resolved
MajesticPotatoe
requested changes
Apr 21, 2021
glen-84
suggested changes
Apr 22, 2021
Co-authored-by: Glen <glen.84@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
resolves #10377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert breakpoint service to display composable.
BREAKING
Motivation and Context
Port v2 breakpoints to v3
How Has This Been Tested?
jest/visually
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).