Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(display): port to v3 #13318

Merged
merged 33 commits into from
Apr 27, 2021
Merged

feat(display): port to v3 #13318

merged 33 commits into from
Apr 27, 2021

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Mar 24, 2021

Description

Convert breakpoint service to display composable.

  • added platform information, mobile, ios, ssr
  • added new xxl breakpoint to display
  • added new xxl breakpoint to css utility classes
  • updated $display-breakpoints
  • simplified code for determining breakpoint information

BREAKING

  • removed xsOnly, smOnly, mdOnly, lgOnly, xlOnly
    • use xs, sm, md, lg, xl, or xxl instead
  • removed scrollbarWidth

Motivation and Context

Port v2 breakpoints to v3

How Has This Been Tested?

jest/visually

Markup:

<template>
  <v-app class="v-application--is-ltr">
    <v-navigation-drawer fixed :model-value="model" />

    <v-main>
      <v-container>
        <v-btn block @click="model = !model">Foo</v-btn>
      </v-container>
    </v-main>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      model: null,
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider changed the title chore: init commit feat(display): port to v3 Mar 26, 2021
@glen-84
Copy link

glen-84 commented Mar 28, 2021

As mentioned on Discord, Window.matchMedia() might be something to consider, depending on your needs.

@johnleider
Copy link
Member Author

As mentioned on Discord, Window.matchMedia() might be something to consider, depending on your needs.

I think this might be best served in the theme composable where it's context makes a little more sense.

@johnleider johnleider added this to In progress in Vuetify 3 - Titan via automation Apr 18, 2021
@johnleider johnleider added this to the v3.0.0 milestone Apr 18, 2021
@johnleider
Copy link
Member Author

Requesting Initial comments from @vuetifyjs/core-team

@Mert75 Mert75 marked this pull request as ready for review April 18, 2021 09:12
Vuetify 3 - Titan automation moved this from In progress to Review in progress Apr 21, 2021
johnleider and others added 14 commits April 22, 2021 09:44
Co-authored-by: Glen <glen.84@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
@johnleider johnleider merged commit a8dba4f into next Apr 27, 2021
Vuetify 3 - Titan automation moved this from Review in progress to Done Apr 27, 2021
@johnleider johnleider deleted the feat/v3-display branch April 27, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants