-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add locale composable #13336
Merged
Merged
feat: add locale composable #13336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I prefer vue-intl (Format.JS). |
Yes, it's optional. And the API here is still very much up in the air. I'll have a look at vue-intl. |
@glen-84 I've reworked the adapter interface to kind of work with vue-intl as well. still very prototypey. |
KaelWD
reviewed
Apr 1, 2021
nekosaur
force-pushed
the
feat/v3-locale
branch
from
April 11, 2021 16:51
2e6739e
to
acf7c84
Compare
This or some version of locale/rtl needs to be merged pretty soon |
johnleider
requested changes
Apr 14, 2021
KaelWD
reviewed
Apr 14, 2021
nekosaur
force-pushed
the
feat/v3-locale
branch
from
April 17, 2021 08:34
b20a6db
to
de3c0b3
Compare
johnleider
requested changes
Apr 23, 2021
packages/vuetify/src/components/VLocaleProvider/VLocaleProvider.tsx
Outdated
Show resolved
Hide resolved
johnleider
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
creates locale and rtl composables.
adapter helpers for vue-i18n and vue-intl are not included here since it would mean we'd need to depend on those packages. they should probably be separate npm packages that can be imported and used.
resolves #13539
Motivation and Context
v3
How Has This Been Tested?
playground. still needs tests
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).