Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VProgressCircular): port to v3 #13597

Merged
merged 17 commits into from Jun 28, 2021
Merged

feat(VProgressCircular): port to v3 #13597

merged 17 commits into from Jun 28, 2021

Conversation

blalan05
Copy link
Member

@blalan05 blalan05 commented May 4, 2021

Resolves #11922

Markup:

<template>
  <v-app>
    <div class="ma-12 pa-12">
      <v-progress-circular model-value="50" />
      <v-progress-circular model-value="50" />
      <v-progress-circular model-value="50" indeterminate />
      <v-progress-circular model-value="50" color="blue" />
      <v-progress-circular model-value="50" color="blue" size="x-large" />
      <v-progress-circular
        model-value="50"
        color="blue"
        size="48"
        width="12"
      />
    </div>
  </v-app>
</template>

<script>
  export default {

  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@blalan05 blalan05 linked an issue May 4, 2021 that may be closed by this pull request
@blalan05 blalan05 changed the title Progress Circular to V3 feat(VProgressCircular): port to v3 May 4, 2021
@KaelWD KaelWD changed the base branch from master to next May 4, 2021 06:40
@nekosaur
Copy link
Member

nekosaur commented May 14, 2021

  • I added support for using small, large, x-large size values to keep things consistent with other components
  • Re-added intersection observer functionality
  • Added bg-color prop. This one I'm a bit unsure of. I think it would be very nice to be able to set background circle color (since it is already possible in progress-linear). However I'm not sure what the default value should be. The current surface color is just white. Something like grey-lighten-1 looks pretty good, but then it will look different if users disable material colors

edit:

  • also I rotated it 90 degrees ccw so that 0 is at the 12 o'clock position

Vuetify 3 - Titan automation moved this from In progress to Review in progress May 29, 2021
@johnleider
Copy link
Member

Can we add different animations? Such as:

image
image
image
image

These are just a few examples / ideas. Does the @vuetifyjs/core-team think that my suggestions are within the scope of this component?

@blalan05
Copy link
Member Author

blalan05 commented Jun 15, 2021

Adding different styles/options could be interesting, but it brings up the question of how much outside of Google MD do we want to implement/provide?

Another question, what would the syntax be to select the style desired, which one is default?
<v-progressive-circular type="growing-dots" />?

@KaelWD
Copy link
Member

KaelWD commented Jun 22, 2021

I don't think that's necessary.

@KaelWD KaelWD force-pushed the feat/v3-progress-circular branch from 50ea6a9 to df608a5 Compare June 22, 2021 15:06
@KaelWD KaelWD force-pushed the feat/v3-progress-circular branch from 365e0fa to cd54414 Compare June 23, 2021 14:43
@KaelWD KaelWD linked an issue Jun 24, 2021 that may be closed by this pull request
@johnleider johnleider merged commit 4f53f61 into next Jun 28, 2021
Vuetify 3 - Titan automation moved this from Review in progress to Done Jun 28, 2021
@johnleider johnleider deleted the feat/v3-progress-circular branch June 28, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VProgressCircular VProgressCircular
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Task] v-progress-circular [Bug Report] Circular progress animation breaks under heavy load
5 participants