New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VCard): port to v3 #13674
feat(VCard): port to v3 #13674
Conversation
5843b18
to
7fc3088
Compare
Some thoughts:
|
|
|
|
yes, something like that
I think the markup becomes very weird though <v-card>
<v-card-item>
<v-card-avatar/>
<v-card-header>
...
</v-card-header>
<v-card-avatar/>
</v-card-item>
<v-card-text/>
</v-card> vs <v-card>
<v-card-header>
<v-card-avatar/>
...
<v-card-avatar/>
</v-card-header>
<v-card-text/>
</v-card> which to me seems more natural |
The only way to align prepend/append with a title/subtitle is if the latter has a wrapper. The following won't work: <v-card>
<v-card-header>
<v-card-avatar />
<v-card-title />
<v-card-subtitle />
<v-card-avatar />
</v-card-header>
</v-card> We need something like this: <v-card>
<v-card-header>
<v-card-avatar />
<v-card-some-component-name>
<v-card-title />
<v-card-subtitle />
</v-card-some-component-name>
<v-card-avatar />
</v-card-header>
</v-card> |
|
Requesting Final comments from @vuetifyjs/core-team |
re-used logic in VBtn to add support for density / size combinations BREAKING CHANGE: the default avatar height is now 40px
Co-authored-by: Elijah Kotyluk <elijah@elijahkotyluk.com>
Description
Here are various implementations of card (the component's specifications are garbage) for reference
Specification
Motivation and Context
Bug fixes
Features
v-card
v-card
v-avatar
Styles
v-btn
forv-card-actions
v-avatar
for densityBreaking changes
Styles
How Has This Been Tested?
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).