-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): theme prop is now available on each component #13718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Feedback is here https://discord.com/channels/340160225338195969/519331123239583755/847520162365833216
Closes #13288. (?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Any api-generator updates that need to be made?
Co-authored-by: John Leider <9064066+johnleider@users.noreply.github.com>
Co-authored-by: John Leider <9064066+johnleider@users.noreply.github.com>
Description
add
theme
prop to each component so that it can override provided value and start new context for it and all childrenNOTE this will add two computed variables for every component. there is no way of conditionally providing values
fixes #13288
TODO
Motivation and Context
How Has This Been Tested?
playground
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).