Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply offset padding to appbars when an overlay is open #13723

Merged
merged 2 commits into from
May 28, 2021

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented May 28, 2021

Markup:

<template>
  <v-app>
    <v-app-bar>
      <template #prepend>
        <v-btn icon="mdi-menu" />
      </template>

      <v-app-bar-title>
        Title
      </v-app-bar-title>

      <template #append>
        <v-btn icon="mdi-download" />

        <v-btn icon="mdi-printer" />

        <v-btn icon="mdi-heart" />
      </template>
    </v-app-bar>

    <v-main>
      <v-container class="pa-0 pa-md-16" style="height: 200vh">
        <v-layout style="height: 600px">
          <v-app-bar absolute>
            <v-app-bar-title>
              Title
            </v-app-bar-title>

            <template #append>
              <v-btn icon="mdi-vuetify"></v-btn>
            </template>
          </v-app-bar>
          <v-main>
            <v-container style="height: 1200px">
              <v-dialog>
                <template #activator="{ props }">
                  <v-btn v-bind="props">Dialog</v-btn>
                </template>
                <v-sheet width="300" height="300">
                  Dialog
                </v-sheet>
              </v-dialog>
              <v-dialog attach absolute>
                <template #activator="{ props }">
                  <v-btn v-bind="props">Attached dialog</v-btn>
                </template>
                <v-sheet width="300" height="300">
                  Attached dialog
                </v-sheet>
              </v-dialog>
              <v-dialog fullscreen>
                <template #activator="{ props }">
                  <v-btn v-bind="props">Fullscreen dialog</v-btn>
                </template>
                <v-sheet width="300" height="300">
                  Fullscreen dialog
                </v-sheet>
              </v-dialog>
            </v-container>
          </v-main>
        </v-layout>
      </v-container>
    </v-main>
  </v-app>
</template>

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VOverlay VOverlay C: VAppBar VAppBar labels May 28, 2021
@KaelWD KaelWD added this to the v3.0.0 milestone May 28, 2021
@KaelWD KaelWD self-assigned this May 28, 2021
@KaelWD KaelWD requested a review from nekosaur May 28, 2021 14:27
<div
class={layoutClasses.value}
style={{
height: props.fullHeight ? '100vh' : undefined,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100vh doesn't really work properly on mobile

@@ -115,7 +115,7 @@ const generateLayers = (
}

// TODO: Remove undefined from layout and overlaps when vue typing for required: true prop is fixed
export function createLayout (props: { layout?: string[], overlaps?: string[] }) {
export function createLayout (props: { layout?: string[], overlaps?: string[], fullHeight?: boolean }) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is props.layout even used here?
  • Can't we use ReturnType<typeof makeLayoutProps>?

@KaelWD KaelWD merged commit febab14 into next May 28, 2021
@KaelWD KaelWD deleted the fix/appbar-dialog-scrollbar-offset branch May 28, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAppBar VAppBar C: VOverlay VOverlay T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants