Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][2.5.2] failure to position menu in main app bar #13740

Closed
albanm opened this issue Jun 2, 2021 · 4 comments
Closed

[Bug Report][2.5.2] failure to position menu in main app bar #13740

albanm opened this issue Jun 2, 2021 · 4 comments
Assignees
Labels
C: VMenu VMenu T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Milestone

Comments

@albanm
Copy link

albanm commented Jun 2, 2021

Environment

Vuetify Version: 2.5.2
Last working version: 2.5.1
Vue Version: 2.6.13
Browsers: Chrome 91.0.4472.77
OS: Linux x86_64

Steps to reproduce

Create a menu to the right of a app bar. The menu used to be opened to the left on its own, now it i opened to the right and so not visible. Also it is impossible to force displaying to the left.

Expected Behavior

display menu to the left

Actual Behavior

menu displayed to the right

Reproduction Link

https://codepen.io/albanm/pen/oNZELeX

@ghost ghost added the S: triage label Jun 2, 2021
@KaelWD KaelWD added C: VMenu VMenu T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke and removed S: triage labels Jun 2, 2021
@ajanes93
Copy link

ajanes93 commented Jun 2, 2021

I am seeing the same issue as OP, on the same environment. It seems this regression was caused by a change in PR #13670. In particular the change to the sneakPeek callback in the menuable mixin. As a very quick test I just added the following line:

_this.$refs.content && (dimensions.content = _this.measure(_this.$refs.content))

to the top of the sneakPeek callback which then causes the Menu to display as expected in the app bar. Hope this helps narrow down what the issue is.

@KaelWD KaelWD self-assigned this Jun 2, 2021
@KaelWD KaelWD added this to the v2.5.x milestone Jun 2, 2021
@KaelWD
Copy link
Member

KaelWD commented Jun 2, 2021

offsetParent returns null in the following situations: [...] The element has the position property set to fixed

@KaelWD KaelWD closed this as completed in ec8fafa Jun 2, 2021
@albanm
Copy link
Author

albanm commented Jun 2, 2021

Thanks. From what you told me on the previous issue I suppose this will be released next tuesday. I think it is quite a big regression, maybe an early relase is warranted ?

@KaelWD
Copy link
Member

KaelWD commented Jun 2, 2021

I'm doing another release today to fix the new sass issues anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VMenu VMenu T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Development

No branches or pull requests

3 participants