Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VDefaultsProvider component #13743

Merged
merged 2 commits into from
Jun 3, 2021
Merged

feat: add VDefaultsProvider component #13743

merged 2 commits into from
Jun 3, 2021

Conversation

nekosaur
Copy link
Member

@nekosaur nekosaur commented Jun 2, 2021

Description

Motivation and Context

How Has This Been Tested?

Markup:

<template>
  <v-app class="fill-height">
    <v-card title="foo" subtitle="bar" class="ma-10" />
    <v-defaults-provider :defaults="defaults">
      <v-card title="foo" subtitle="bar" class="ma-10" />
    </v-defaults-provider>
  </v-app>
</template>

<script>
  import { ref } from 'vue'

  export default {
    name: 'Playground',
    setup () {
      const defaults = ref({
        global: {
          elevation: 10,
        },
        VCard: {
          color: 'primary',
        },
      })

      return { defaults }
    },
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@nekosaur nekosaur self-assigned this Jun 2, 2021
@nekosaur nekosaur added the C: New Component This issue would need a new component to be developed. label Jun 2, 2021
@nekosaur nekosaur added this to In progress in Vuetify 3 - Titan via automation Jun 2, 2021
@nekosaur nekosaur added this to the v3.0.0 milestone Jun 2, 2021
@johnleider johnleider added the T: feature A new feature label Jun 2, 2021
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much I see in the way of changes needed, only chore/doc stuff really.

Vuetify 3 - Titan automation moved this from In progress to Review in progress Jun 2, 2021
@nekosaur nekosaur requested a review from johnleider June 3, 2021 19:33
Vuetify 3 - Titan automation moved this from Review in progress to Reviewer approved Jun 3, 2021
@nekosaur nekosaur merged commit 984738f into next Jun 3, 2021
Vuetify 3 - Titan automation moved this from Reviewer approved to Done Jun 3, 2021
@nekosaur nekosaur deleted the feat/defaults-provider branch June 3, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: New Component This issue would need a new component to be developed. T: feature A new feature
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants