Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDialog): resolve style inconsistencies and structure #13848

Merged
merged 3 commits into from Jun 28, 2021

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Jun 26, 2021

Description

Move component level dialog styles to their respective sass files. Refactored to match MD2 spec.

Motivation and Context

  • fix broken spec
  • clean-up style implementation

Added the following sass variables:

  • $card-avatar-dialog-padding
  • $card-dialog-elevation
  • $card-header-dialog-padding
  • $card-header-dialog-text-padding-top
  • $card-text-dialog-letter-spacing
  • $card-text-dialog-padding
  • $overlay-dialog-border-radius
  • $overlay-dialog-max-height
  • $overlay-dialog-max-width
  • $overlay-dialog-min-width
  • $overlay-dialog-mobile-breakpoint
  • $overlay-dialog-mobile-max-width
  • $sheet-dialog-elevation

BREAKING

Moved or removed the following sass variables:

  • $dialog-border-radius -> $overlay-dialog-border-radius
  • $dialog-card-actions-padding -> removed
  • $dialog-card-subtitle-padding -> removed
  • $dialog-card-text-padding -> $card-text-dialog-padding
  • $dialog-card-title-font-size -> removed
  • $dialog-card-title-font-weight -> removed
  • $dialog-card-title-letter-spacing -> removed
  • $dialog-card-title-padding -> $card-header-dialog-padding
  • $dialog-elevation -> $card-dialog-elevation or $sheet-dialog-elevation
  • $dialog-margin -> removed
  • $dialog-max-height -> $overlay-dialog-max-height

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <v-container style="height: 2500px">
      <v-dialog v-model="active">
        <template #activator="{ isActive, props }">
          <v-btn v-bind="props">{{ isActive ? 'Close' : 'Open' }} dialog</v-btn>
        </template>

        <!-- <v-sheet>
          <div class="pa-4">
            Lorem ipsum dolor sit amet consectetur adipisicing elit. Earum similique numquam consequatur excepturi dolorum molestiae repellendus dolore at, ipsum nobis sunt repudiandae sit dolores nulla repellat eius veniam, nisi sed.
          </div>
        </v-sheet> -->

        <v-card title="Dialog header" text="Lorem ipsum dolor sit, amet consectetur adipisicing elit. Aut modi iusto ipsum molestiae doloribus rerum nulla amet eaque excepturi magni quaerat, libero porro, eligendi delectus neque sed quasi, quod sit!">
          <!-- <template #append>
              <v-btn variant="text" density="compact" icon="$close" @click="isActive.value = false" />
            </template> -->

          <template #actions>
            <v-spacer />

            <v-btn>Action 1</v-btn>

            <v-btn>Action 2</v-btn>
          </template>
        </v-card>
      </v-dialog>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      active: true,
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider self-assigned this Jun 26, 2021
@johnleider johnleider added C: VDialog VDialog md2 The issue pertains to Material Spec 2 T: bug Functionality that does not work as intended/expected labels Jun 26, 2021
@johnleider johnleider added this to In progress in Vuetify 3 - Titan via automation Jun 26, 2021
@johnleider johnleider added this to the v3.0.0 milestone Jun 26, 2021
@johnleider
Copy link
Member Author

Requesting Initial comments from @vuetifyjs/core-team

@johnleider johnleider requested a review from a team June 26, 2021 14:21
@johnleider johnleider marked this pull request as ready for review June 27, 2021 14:29
@johnleider johnleider merged commit 9c2e363 into next Jun 28, 2021
Vuetify 3 - Titan automation moved this from In progress to Done Jun 28, 2021
@johnleider johnleider deleted the fix/v3-dialog-styles branch June 28, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDialog VDialog md2 The issue pertains to Material Spec 2 T: bug Functionality that does not work as intended/expected
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant