Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VAlert): port to v3 #13855

Merged
merged 13 commits into from Jul 1, 2021
Merged

feat(VAlert): port to v3 #13855

merged 13 commits into from Jul 1, 2021

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Jun 28, 2021

Description

Ported component and added new styles from variants and density.

  • Added a default background for an untyped alert
  • Changed dismissible to closable
  • Text prop now applies to textual content, replaced by variant=contained-text

Motivation and Context

I'm motivated to finish Phase 2

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <div class="ma-2 pa-2">
      <v-alert :text="text" tip type="info" />

      <div class="my-6" />

      <v-alert
        v-for="density in ['default', 'comfortable', 'compact']"
        :key="density"
        text="Lorem ipsum dolor sit amet consectetur adipisicing elit"
        :closable="closable"
        :density="density"
        class="mb-4"
        prominent
        type="error"
        variant="contained"
      />

      <v-alert
        v-for="density in ['default', 'comfortable', 'compact']"
        :key="density"
        text="Lorem ipsum dolor sit amet consectetur adipisicing elit"
        :closable="closable"
        :density="density"
        class="mb-4"
        type="error"
        variant="plain"
      />
      <div class="my-12" />
      <v-alert icon="mdi-check-circle" :text="text" :closable="closable" />
      <div class="my-12" />
      <v-alert icon="mdi-check-circle" prominent :text="text" :closable="closable" />
      <div class="my-12" />
      <v-alert prominent icon="mdi-check-circle" text="Lorem ipsum dolor sit amet consectetur adipisicing elit" :closable="closable" />
      <v-alert type="info" :text="text" />
      <v-alert type="warning" :text="text" />
      <v-alert type="error" :text="text" />

      <div class="my-6" />

      <v-alert type="success" :text="text" prominent elevation="24" />

      <div class="my-6" />

      <v-alert
        :text="text"
        border="start"
        type="success"
        class="border-opacity"
        rounded="0"
      />

      <v-alert
        :text="text"
        border="start"
        type="success"
        rounded="0"
      />

      <div class="my-6" />

      <v-alert type="success" :text="text" prominent density="compact" />

      <div class="my-6" />
    </div>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      closable: true,
      text: 'Lorem ipsum dolor sit amet consectetur adipisicing elit. Vero ducimus consequatur laboriosam quasi fuga quod. Veritatis ab molestias ipsam perspiciatis! Dolores a corrupti voluptates ut non velit cumque quasi inventore.',
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added this to the v3.0.0 milestone Jun 28, 2021
@johnleider johnleider self-assigned this Jun 28, 2021
@johnleider johnleider added this to In progress in Vuetify 3 - Titan via automation Jun 28, 2021
@johnleider johnleider mentioned this pull request Jun 28, 2021
@johnleider
Copy link
Member Author

Requesting Initial comments from @vuetifyjs/core-team

@johnleider johnleider marked this pull request as ready for review June 30, 2021 21:48
@KaelWD

This comment has been minimized.

@johnleider
Copy link
Member Author

Requesting Final comments from @vuetifyjs/core-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants