-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VCalendar): add nativeEvent to all re-emitted events #14307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
previously approved these changes
Oct 23, 2021
glen-84
added
C: VCalendar
VCalendar
T: bug
Functionality that does not work as intended/expected
labels
Oct 24, 2021
KaelWD
added
the
S: has merge conflicts
The pending Pull Request has merge conflicts
label
Oct 31, 2021
Ok, @KaelWD I will work on this in the next days. |
KaelWD
removed
the
S: has merge conflicts
The pending Pull Request has merge conflicts
label
Nov 3, 2021
KaelWD
reviewed
Nov 30, 2021
KaelWD
approved these changes
Nov 30, 2021
KaelWD
changed the title
fix(VCalendar): add native event on :time and :date event
fix(VCalendar): add nativeEvent to all re-emitted events
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9485
This PR allow calendar event emit the native event (MouseEvent, etc...) in :time and :date custom event.
Before native event was pass only on the :event event.
Motivation and Context
This change is require for all features which need raw event information. Like open a context menu at the click position.
Fix issue issue #14298.
How Has This Been Tested?
Test with log information. In fact this PR don't affect beheavior of the VCalendar, just add information.
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).