-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VRipple): use $ripple-animation-visible-opacity variable #14365
Conversation
$ripple-animation-transition-in: transform .25s map-get($transition, 'fast-in-slow-out'), | ||
opacity .1s map-get($transition, 'fast-in-slow-out') !default; | ||
$ripple-animation-transition-out: opacity .3s map-get($transition, 'fast-in-slow-out') !default; | ||
$ripple-animation-visible-opacity: .15 !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer this file over the global one if the variables aren't used anywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've thought about that. but the problem is that it won't be documented! if it's written only in ripple variable.scss
.
directives are not mentioned in Sass variables page
If I keep it in global variable it'll be added to $vuetify
object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok remove this file entirely then if it does nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
Description
fixes #11505
packages/vuetify/src/directives/ripple/_variables.scss
as they are already defined inpackages\vuetify\src\styles\settings\_variables.scss
Vripple index.ts
as it overrides the opactiy in sass fileopacity
variable, functionality into sass fileMotivation and Context
How Has This Been Tested?
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).