Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][2.6.0] Width of vBottomSheet is broken #14419

Closed
AndreyYolkin opened this issue Nov 20, 2021 · 0 comments
Closed

[Bug Report][2.6.0] Width of vBottomSheet is broken #14419

AndreyYolkin opened this issue Nov 20, 2021 · 0 comments
Assignees
Labels
C: VBottomSheet VBottomSheet C: VDialog VDialog T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Milestone

Comments

@AndreyYolkin
Copy link
Contributor

Environment

Vuetify Version: 2.6.0
Last working version: 2.5.14
Vue Version: 2.6.14
Browsers: Google Chrome, Mozilla Firefox
OS: Windows 11

Steps to reproduce

  1. Add v-bottom-sheet component in application without explicitly setting the width of this sheet
  2. Toggle vBottomSheet display

Expected Behavior

Width of sheet is 100% of parent dialog width

Actual Behavior

Width fits to the internal content

Reproduction Link

https://codesandbox.io/s/vuetify-2-6-0-broken-v-bottom-sheet-example-47zow

Other comments

I've found this is happening because there is no rule
.v-dialog>* { width: 100%; }
In 2.6.0, but it existed in previous versions.

I also made 2 sandboxes, which differs only with Vuetify version and colors:
https://codesandbox.io/s/vuetify-2-6-0-broken-v-bottom-sheet-example-47zow
https://codesandbox.io/s/vuetify-2-5-x-working-v-bottom-sheet-example-pcmv3

Possibly fixed by the next rule:
.v-bottom-sheet.v-dialog>.v-sheet { width: 100%; }

@KaelWD KaelWD self-assigned this Nov 21, 2021
@KaelWD KaelWD added C: VBottomSheet VBottomSheet C: VDialog VDialog T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke and removed S: triage labels Nov 21, 2021
@KaelWD KaelWD added this to the v2.6.x milestone Nov 21, 2021
@KaelWD KaelWD closed this as completed in ef8b3cc Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VBottomSheet VBottomSheet C: VDialog VDialog T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Development

No branches or pull requests

2 participants