Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): add xxl border-radius option #14546

Merged
merged 2 commits into from Jun 7, 2023

Conversation

KareemDa
Copy link
Contributor

Description

add option: 2xl to border radius

Motivation and Context

th step between lg, xl was too big, So I've added new value between

old code:

  • 'lg': $border-radius-root * 2
  • 'xl': $border-radius-root * 6

new code:

  • 'lg': $border-radius-root * 2
  • 'xl': $border-radius-root * 4
  • '2xl': $border-radius-root * 6

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KareemDa KareemDa changed the title fixes 14368: add new border-radius option feat(SASS): add 2xl border-radius option Dec 25, 2021
@johnleider johnleider added the S: on hold The issue is on hold until further notice label Jun 30, 2022
@KaelWD KaelWD changed the base branch from dev to v2-dev December 7, 2022 15:08
@KaelWD KaelWD added this to the v2.7.0 (Nirvana) milestone Mar 23, 2023
@johnleider johnleider added T: feature A new feature sass and removed S: on hold The issue is on hold until further notice labels Jun 7, 2023
@KaelWD KaelWD changed the title feat(SASS): add 2xl border-radius option feat(styles): add xxl border-radius option Jun 7, 2023
@KaelWD KaelWD merged commit 018525e into vuetifyjs:v2-dev Jun 7, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sass T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants