fix(VCarouselItem): correctly renders placeholder slot in v-img #14686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8452 from regression caused by the commit 2b975f5
The
VCarouselItem
component doesn't render theplaceholder
slot correctly.It's failing because we're considering it's a
scopedSlot
instead of just aslot
when theVCarouselItem
renders theVImg
. But onVImg
there is a condition that only checks for theslots
, not thescopedSlots
:So I just rendered the slot using a
template
children so the condition can pass and actually render the placeholder :)I noticed this commit actually changed from
slots
toscopedSlot
but I'm not sure what was the purpose of the change. Maybe I'm missing something that made it legit to usescopedSlot
?Note: do you want me to create an issue before, and link it on this PR?
Motivation and Context
How Has This Been Tested?
I added a unit test for this specific slot, testing it is correctly rendered within the
VImg
.I had to update a snapshot for
VOverflowBtn
since it was failing. I guess it's failing on master too since I didn't touched this component.Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).