Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Imports from the docs failing & missing TS decls. #14875

Open
Piezoid opened this issue Mar 25, 2022 · 0 comments
Open

[Documentation] Imports from the docs failing & missing TS decls. #14875

Piezoid opened this issue Mar 25, 2022 · 0 comments
Assignees
Labels
C: Transitions maybe Functionality that we are considering T: documentation
Milestone

Comments

@Piezoid
Copy link

Piezoid commented Mar 25, 2022

Environment

Vuetify Version: 3.0.0-beta.0
Vue Version: 3.2.31
Browsers: Firefox 98.0, Google Chrome
OS: Linux x86_64

Steps to reproduce

I took a look at public APIs from the docs:

import { createSimpleTransition } from 'vuetify/lib/components/transitions/createTransition'
const myTransition = createSimpleTransition('my-transition')

createSimpleTransition was renamed createCssTransition

import { createVueI18nAdapter } from 'vuetify/locale/adapters/vue-i18n'

No typescript declarations available.

Expected Behavior

  • New exports should be:
import { createCssTransition, createJavascriptTransition } from 'vuetify/lib/components/transitions/createTransition.mjs'.
  • createJavascriptTransition should be documented

  • createVueI18nAdapter should be available in typescript declaration files

  • The package should publish (or re-export) declarations from components/transitions/createTransition.d.ts and locale/adapters/vue-i18n.d.ts. Having util/colors.d.ts would be nice too (even if it's no longer in the docs).

Actual Behavior

Export from the docs fail, missing typescript declarations.

Reproduction Link

https://next.vuetifyjs.com/en/styles/transitions/#create-your-own

@Piezoid Piezoid changed the title [Documentation] Umports from the docs failing & missing TS decls. [Documentation] Imports from the docs failing & missing TS decls. Mar 25, 2022
@KaelWD KaelWD added this to the v3.0.0-beta milestone Jul 5, 2022
@johnleider johnleider modified the milestones: v3.0.0-beta, v3.0.x Aug 9, 2022
@KaelWD KaelWD removed the S: triage label Aug 10, 2022
@KaelWD KaelWD modified the milestones: v3.0.x, v3.1.x Jan 6, 2023
@johnleider johnleider removed this from the v3.1.x milestone Mar 27, 2023
@johnleider johnleider added this to the v3.x.x milestone Sep 20, 2023
@johnleider johnleider added maybe Functionality that we are considering C: Transitions labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Transitions maybe Functionality that we are considering T: documentation
Projects
None yet
Development

No branches or pull requests

5 participants