Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTextField): show counter if using hide-details="auto" #15268

Merged
merged 2 commits into from Jul 14, 2022

Conversation

nekosaur
Copy link
Member

@nekosaur nekosaur commented Jun 9, 2022

closes #15231
closes #15149

Description

Motivation and Context

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <div>
      <v-text-field
        counter
        label="Counter test"
        hideDetails="auto"
      ></v-text-field>
    </div>
  </v-app>
  </template>

<script>
  import { defineComponent } from 'vue'

  export default defineComponent({
    data: () => ({
      model: {
        tab: 'A',
        show: true,
      },
    }),
  })
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@nekosaur nekosaur added this to the v3.0.0-beta milestone Jun 9, 2022
@nekosaur nekosaur requested a review from johnleider June 9, 2022 20:39
@nekosaur nekosaur self-assigned this Jun 9, 2022
@nekosaur nekosaur force-pushed the fix/15231-hide-details-auto-counter branch from 31b66f3 to b112a58 Compare June 9, 2022 20:42
@nekosaur nekosaur force-pushed the fix/15231-hide-details-auto-counter branch from b112a58 to fda2b00 Compare June 29, 2022 18:06
@johnleider johnleider requested a review from KaelWD July 5, 2022 17:25
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VTextField VTextField C: VInput VInput C: VFileInput labels Jul 5, 2022
@johnleider johnleider merged commit a63a838 into next Jul 14, 2022
@johnleider johnleider deleted the fix/15231-hide-details-auto-counter branch July 14, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VFileInput C: VInput VInput C: VTextField VTextField T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants