Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VToolbar): v-btn location in and outside of prepend/append elements #15350

Merged
merged 1 commit into from Jun 30, 2022

Conversation

johnleider
Copy link
Member

Description

Adjust v-btn location depending upon it's location in v-toolbar.

Motivation and Context

Visual consistency

How Has This Been Tested?

visually

Markup:

<template>
  <v-app>
    <v-main>
      <div>
        <v-container>
          <v-toolbar>
            <template #prepend>
              <v-app-bar-nav-icon />
            </template>

            <v-toolbar-title class="text-h6">
              Messages
            </v-toolbar-title>

            <template #append>
              <v-btn icon="mdi-dots-vertical" />
            </template>
          </v-toolbar>
          <br>
          <br>
          <v-toolbar density="compact">
            <v-app-bar-nav-icon />

            <v-toolbar-title class="text-h6">
              Messages
            </v-toolbar-title>

            <template #append>
              <v-btn icon="mdi-dots-vertical" />
            </template>
          </v-toolbar>
        </v-container>
      </div>
    </v-main>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      messages: [
        {
          from: 'You',
          message: `Sure, I'll see you later.`,
          time: '10:42am',
          color: 'deep-purple lighten-1',
        },
        {
          from: 'John Doe',
          message: 'Yeah, sure. Does 1:00pm work?',
          time: '10:37am',
          color: 'green',
        },
        {
          from: 'You',
          message: 'Did you still want to grab lunch today?',
          time: '9:47am',
          color: 'deep-purple lighten-1',
        },
      ],
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider self-assigned this Jun 28, 2022
@johnleider johnleider added C: VToolbar VToolbar T: bug Functionality that does not work as intended/expected labels Jun 28, 2022
@johnleider johnleider added this to the v3.0.0-beta milestone Jun 28, 2022
@ElijahKotyluk ElijahKotyluk merged commit 1335939 into next Jun 30, 2022
@ElijahKotyluk ElijahKotyluk deleted the fix/v-toolbar-btn-margin branch June 30, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VToolbar VToolbar T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants