Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transitions): apply default transition to component transitions #15385

Merged
merged 3 commits into from Jul 14, 2022

Conversation

johnleider
Copy link
Member

closes #14440

Description

add default transition to custom component transitions

Motivation and Context

add transition animations

How Has This Been Tested?

visually

Markup:

<template>
  <v-app>
    <v-main>
      <v-row justify="space-around">
        <v-col cols="auto">
          <v-dialog
            transition="dialog-bottom-transition"
            max-width="600"
          >
            <template #activator="{ props }">
              <v-btn
                color="primary"
                v-bind="props"
              >From the bottom</v-btn>
            </template>
            <template #default="dialog">
              <v-card>
                <v-toolbar
                  color="primary"
                  dark
                >Opening from the bottom</v-toolbar>
                <v-card-text>
                  <div class="text-h2 pa-12">Hello world!</div>
                </v-card-text>
                <v-card-actions class="justify-end">
                  <v-btn
                    text
                    @click="dialog.value = false"
                  >Close</v-btn>
                </v-card-actions>
              </v-card>
            </template>
          </v-dialog>
        </v-col>

        <v-col cols="auto">
          <v-dialog
            transition="dialog-top-transition"
            max-width="600"
          >
            <template #activator="{ props }">
              <v-btn
                color="primary"
                v-bind="props"
              >From the top</v-btn>
            </template>
            <template #default="dialog">
              <v-card>
                <v-toolbar
                  color="primary"
                  dark
                >Opening from the top</v-toolbar>
                <v-card-text>
                  <div class="text-h2 pa-12">Hello world!</div>
                </v-card-text>
                <v-card-actions class="justify-end">
                  <v-btn
                    text
                    @click="dialog.value = false"
                  >Close</v-btn>
                </v-card-actions>
              </v-card>
            </template>
          </v-dialog>
        </v-col>
      </v-row>
    </v-main>
  </v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added T: bug Functionality that does not work as intended/expected E: transition Transition composable labels Jul 5, 2022
@johnleider johnleider added this to the v3.0.0-beta milestone Jul 5, 2022
@johnleider johnleider requested a review from KaelWD July 5, 2022 20:14
@johnleider johnleider self-assigned this Jul 5, 2022
@KaelWD KaelWD changed the title fix(transitions.scss): apply default transition to component transitions fix(transitions): apply default transition to component transitions Jul 6, 2022
@KaelWD
Copy link
Member

KaelWD commented Jul 6, 2022

Most of these aren't even used anymore, should we just remove them? Some seem to be specified in the component stylesheets instead.

@KaelWD KaelWD force-pushed the fix/14440-custom-dialog-transition branch from fac232d to e1c5d34 Compare July 6, 2022 15:00
@johnleider johnleider merged commit c59ec9a into next Jul 14, 2022
@johnleider johnleider deleted the fix/14440-custom-dialog-transition branch July 14, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: transition Transition composable T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants