Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VPagination): remove VBtn defaults, add activeColor prop #15449

Merged
merged 2 commits into from Jul 25, 2022

Conversation

nekosaur
Copy link
Member

closes #15424

Description

  • used _as to set VBtn in VPagination to VPaginationBtn instead.
  • added active-color prop

Motivation and Context

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <v-pagination
      v-model="page"
      :length="6"
      active-color="success"
    ></v-pagination>
  </v-app>

</template>

<script>
  export default {
    data: () => ({
      page: 1,
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@nekosaur nekosaur requested a review from johnleider July 15, 2022 15:59
@nekosaur nekosaur self-assigned this Jul 15, 2022
@johnleider johnleider added this to the v3.0.0-beta milestone Jul 25, 2022
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VPagination VPagination labels Jul 25, 2022
@johnleider johnleider changed the title fix(VPagination): do not use VBtn defaults, add activeColor prop fix(VPagination): remove VBtn defaults, add activeColor prop Jul 25, 2022
@johnleider johnleider merged commit b0df2d0 into next Jul 25, 2022
@johnleider johnleider deleted the fix/15424-pagination-color branch July 25, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VPagination VPagination T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants