Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VChip): highlight overlay on hover #15909

Merged
merged 3 commits into from Oct 24, 2022

Conversation

xignp
Copy link
Contributor

@xignp xignp commented Oct 16, 2022

Description

fixes #15853
v-chip's backgroundcolor will be hightlight when mouse hover

Motivation and Context

How Has This Been Tested?

Playground.vue

Markup:

<template>
  <v-app>
    <v-container>
      <v-chip>non-clickable</v-chip>
      <v-chip @click="chipClick">clickable</v-chip>
    </v-container>
  </v-app>
</template>

<script>
export default {
  name: "Playground",
  setup() {
    const chipClick = () => {
      console.log("clicked")
    }
    return {
      chipClick
    };
  },
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VChip VChip labels Oct 24, 2022
@johnleider johnleider added this to the v3.0.0-beta milestone Oct 24, 2022
@johnleider johnleider changed the title fix(VChip): highlight bgcolor on mouse hover fix(VChip): highlight overlay on hover Oct 24, 2022
@johnleider johnleider merged commit f6cf894 into vuetifyjs:next Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VChip VChip T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants