Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VListItem): infer link if click event is bound #16038

Merged
merged 4 commits into from Nov 10, 2022

Conversation

NoraH1to
Copy link
Contributor

@NoraH1to NoraH1to commented Nov 6, 2022

Description

fixes #16014

Motivation and Context

How Has This Been Tested?

Markup:

<template>
  <v-container>
    <v-menu>
      <template #activator="{props}">
        <v-btn v-bind="props">
          Dropdown Menu
        </v-btn>
      </template>
      <v-list>
        <v-list-item title="cursor = pointer" link="foo" />
        <v-list-item title="cursor != pointer" @click="foo" />
      </v-list>
    </v-menu>
  </v-container>
</template>

<script>
export default {
  methods: {
    foo() {
      console.log("foo");
    }
  }
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VListItem VListItem labels Nov 7, 2022
@johnleider johnleider added this to the v3.0.x milestone Nov 7, 2022
@NoraH1to NoraH1to force-pushed the fix/16014-list-item-clickable-style branch from bb59cf6 to d9ce4ff Compare November 8, 2022 10:53
@NoraH1to NoraH1to force-pushed the fix/16014-list-item-clickable-style branch 2 times, most recently from 6d7a48c to 6c5f873 Compare November 8, 2022 10:58
@NoraH1to NoraH1to requested a review from KaelWD November 8, 2022 11:05
@KaelWD KaelWD changed the title fix(VListItem): should be clickable style when there is only @click fix(VListItem): infer link if click event is bound Nov 10, 2022
@KaelWD KaelWD merged commit af5b5c6 into vuetifyjs:next Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VListItem VListItem T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants