Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VList): prevent scroll on keyboard navigation #16039

Merged
merged 1 commit into from Nov 8, 2022

Conversation

jacekkarczmarczyk
Copy link
Member

Description

fixes #16034

How Has This Been Tested?

playground

Markup:

<template>
  <div style="height: 2000px">
    <v-select
      v-model="select"
      :items="['foo', 'bar', 'baz', 'fizz', 'buzz']"
      label="Select"
    />
    <v-combobox
      v-model="select"
      :items="['foo', 'bar', 'baz', 'fizz', 'buzz']"
      label="Select"
    />
    <v-autocomplete
      v-model="select"
      :items="['foo', 'bar', 'baz', 'fizz', 'buzz']"
      label="Select"
    />
  </div>
</template>

<script setup>
  const select = null
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected C: VSelect VSelect C: VCombobox VCombobox C: VAutocomplete VAutocomplete labels Nov 6, 2022
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Nov 6, 2022
@KaelWD KaelWD added this to the v3.0.x milestone Nov 8, 2022
@KaelWD KaelWD changed the title fix(VSelect,VAutocomplete,VCombobox): keyboard navigation scrolls the page fix(VList): prevent scroll on keyboard navigation Nov 8, 2022
@KaelWD KaelWD merged commit a85c942 into next Nov 8, 2022
@KaelWD KaelWD deleted the fix/#16034-select-keyboard-page-scroll branch November 8, 2022 05:51
NoraH1to pushed a commit to NoraH1to/vuetify that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox C: VList VList C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants