Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse all colors to rgba objects instead of numbers #16052

Merged
merged 4 commits into from Dec 6, 2022
Merged

fix: parse all colors to rgba objects instead of numbers #16052

merged 4 commits into from Dec 6, 2022

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Nov 9, 2022

fixes #16045

@KaelWD KaelWD added T: enhancement Functionality that enhances existing features E: theme Theme composable labels Nov 9, 2022
@KaelWD KaelWD added this to the v3.0.x milestone Nov 9, 2022
@KaelWD KaelWD requested a review from nekosaur November 9, 2022 08:54
johnleider
johnleider requested changes Nov 14, 2022
View reviewed changes
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mark all of the instances of a existing but you get the point.

packages/vuetify/src/components/VColorPicker/VColorPicker.tsx Show resolved Hide resolved
packages/vuetify/src/components/VColorPicker/util/index.ts Show resolved Hide resolved
packages/vuetify/src/components/VColorPicker/util/index.ts Show resolved Hide resolved
packages/vuetify/src/util/colorUtils.ts Show resolved Hide resolved
@KaelWD KaelWD merged commit df03cea into next Dec 6, 2022
@KaelWD KaelWD deleted the fix/proper-hexa-parsing branch December 6, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekkarczmarczyk jacekkarczmarczyk jacekkarczmarczyk left review comments

@johnleider johnleider johnleider approved these changes

@nekosaur nekosaur Awaiting requested review from nekosaur

Assignees

@KaelWD KaelWD

Labels
E: theme Theme composable T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v3.0.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KaelWD @johnleider @jacekkarczmarczyk