Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VCard): removed duplicated style properties #16105

Merged
merged 1 commit into from Nov 17, 2022
Merged

fix(VCard): removed duplicated style properties #16105

merged 1 commit into from Nov 17, 2022

Conversation

vexleet
Copy link
Contributor

@vexleet vexleet commented Nov 16, 2022 •
edited

VCard.sass had some properties, which were hardcoded and were overwriting the properties that were using variables. I removed them and now VCard styles is using only variables (where needed)

fix #16095

Description

Motivation and Context

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vexleet
fix(v-card): removed duplicated style properties
19a1d27 
VCard.sass had some properties, which were hardcoded and were overwriting the properties that were
using variables. I removed them and now VCard styles is using only variables (where needed)

fix vuetifyjs#16095
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VCard VCard labels Nov 17, 2022
@johnleider johnleider added this to the v3.0.x milestone Nov 17, 2022
@johnleider johnleider changed the title fix(v-card): removed duplicated style properties fix(VCard): removed duplicated style properties Nov 17, 2022
@johnleider johnleider merged commit e9fe8ab into vuetifyjs:next Nov 17, 2022
mhio pushed a commit to mhio/issue-vuetify that referenced this pull request Nov 26, 2022
@vexleet @mhio
fix(VCard): removed duplicated style properties (vuetifyjs#16105)
ae3fd9f 
fixes vuetifyjs#16095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnleider johnleider johnleider approved these changes

Assignees

@vexleet vexleet

Labels
C: VCard VCard T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.0.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vexleet @johnleider