Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): unwrap refs in this.$vuetify #16193

Merged
merged 1 commit into from Dec 6, 2022
Merged

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Nov 30, 2022

Description

Typing for this.$vuetify doesn't unwrap refs
Discussion on discord: https://discord.com/channels/340160225338195969/660898563139567625/1047548064866521110

How Has This Been Tested?

wasn't (due to some unrelated technical problems)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Alternative solution

  interface Vuetify {
    defaults: DefaultsInstance
    display: DisplayInstance
    theme: ThemeInstance
    icons: IconOptions
    locale: LocaleInstance & RtlInstance
  }

  export interface ComponentCustomProperties {
    $vuetify: UnwrapNestedRefs<Vuetify>
  }

@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Nov 30, 2022
@jacekkarczmarczyk jacekkarczmarczyk changed the title fix(types): invalid type of this. in Options API fix(types): invalid type of this.$vuetify in Options API Nov 30, 2022
@johnleider johnleider added this to the v3.0.x milestone Dec 5, 2022
@KaelWD KaelWD changed the title fix(types): invalid type of this.$vuetify in Options API fix(types): unwrap refs in this.$vuetify Dec 6, 2022
@KaelWD KaelWD merged commit fb84480 into next Dec 6, 2022
@KaelWD KaelWD deleted the fix/options-api-interface branch December 6, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants