Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validation): enforce validation maxErrors #16202

Merged
merged 1 commit into from Dec 5, 2022

Conversation

jacekkarczmarczyk
Copy link
Member

Description

fixes #16197

How Has This Been Tested?

playground, unit

Markup:

<script setup>
  import { ref } from 'vue'

  const errors = ref(['error 1', 'error 2'])
  const rules = ['error 1', 'error 2']
</script>

<template>
  <v-app>
    <v-main>
      <v-text-field label="Error 2 should not be visible" :error-messages="errors" :max-errors="1" />
      <v-text-field label="Error 2 should not be visible" placeholder="Edit me" persistent-placeholder :rules="rules" :max-errors="1" />
    </v-main>
  </v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected E: validation labels Dec 1, 2022
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Dec 1, 2022
@johnleider johnleider added this to the v3.0.x milestone Dec 5, 2022
@johnleider johnleider changed the title fix(validation): maxErrors is ignored when using errorMessages prop fix(validation): enforce validation maxErrors Dec 5, 2022
@johnleider johnleider merged commit 13d156c into next Dec 5, 2022
@johnleider johnleider deleted the fix/#16197-v-input-max-errors branch December 5, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: validation T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants