Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VChip): component always shows cursor pointer #16256

Merged
merged 1 commit into from Dec 10, 2022

Conversation

zeljic
Copy link
Contributor

@zeljic zeljic commented Dec 9, 2022

Description

Instead of isClickable.value only isClickable is used as value to check if v-chip component should add link class to component.

Motivation and Context

I did found it using latest version of library, it looks strange if there is no real action after click.

How Has This Been Tested?

visually

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD KaelWD changed the title fix(VChip): Component always shows cursor pointer fix(VChip): component always shows cursor pointer Dec 10, 2022
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VChip VChip labels Dec 10, 2022
@KaelWD KaelWD added this to the v3.0.x milestone Dec 10, 2022
@KaelWD KaelWD merged commit 420af68 into vuetifyjs:next Dec 10, 2022
@zeljic zeljic deleted the fix/vchip-cursor-issue branch December 10, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VChip VChip T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants