Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VSkeletonLoader): apply aria-label for screenreaders #17073

Merged
merged 3 commits into from Jul 5, 2023
Merged

fix(VSkeletonLoader): apply aria-label for screenreaders #17073

merged 3 commits into from Jul 5, 2023

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Apr 3, 2023 •
edited

fixes #10999

@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VSkeletonLoader labels Apr 3, 2023
@johnleider johnleider added this to the v2.7.0 (Nirvana) milestone Apr 3, 2023
@johnleider johnleider requested a review from KaelWD April 3, 2023 18:11
@johnleider johnleider self-assigned this Apr 3, 2023
@KaelWD KaelWD mentioned this pull request Jun 7, 2023
Closed
@KaelWD KaelWD changed the title fix(VSkeletonLoader): apply aria-label for sr fix(VSkeletonLoader): apply aria-label for screenreaders Jul 5, 2023
@KaelWD KaelWD merged commit a0d8d34 into v2-dev Jul 5, 2023
7 of 8 checks passed
@KaelWD KaelWD deleted the fix/10999-skeleton-aria branch July 5, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaelWD KaelWD Awaiting requested review from KaelWD

Assignees

@johnleider johnleider

Labels
C: VSkeletonLoader T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.7.0 (Nirvana)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnleider @KaelWD