Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSelect): replace onfocusout with onAfterleave #17218

Merged
merged 2 commits into from
May 3, 2023
Merged

fix(VSelect): replace onfocusout with onAfterleave #17218

merged 2 commits into from
May 3, 2023

Conversation

yuwu9145
Copy link
Member

@yuwu9145 yuwu9145 commented Apr 24, 2023

fix #17214

Description

Cause:

VMenu is removed when enter key to select, on firefox, when element is removed, onfocusout is not triggered.

This onfocusout bug is confirmed on firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1829602

Markup:

<template>
  <v-app>
    <v-main>
      <v-container>
        <v-autocomplete
          label="Label 1"
          name="label1"
          :items="items"
        />
        <v-autocomplete
          label="Label 2"
          name="label2"
          :items="items"
        />
        <v-select
          label="Label 2"
          name="label2"
          :items="items"
        />
        <v-combobox
          label="Label 2"
          name="label2"
          :items="items"
        />
        <v-btn>
        	Label 3
        </v-btn>
      </v-container>
    </v-main>
  </v-app>
</template>

<script setup>
    const items = [
        "Item 1",
        "Item 2",
        "Item 3",
    ];
</script>

@yuwu9145 yuwu9145 marked this pull request as ready for review April 28, 2023 12:25
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VSelect VSelect C: VCombobox VCombobox C: VAutocomplete VAutocomplete labels May 3, 2023
@KaelWD KaelWD added this to the v3.2.x milestone May 3, 2023
@KaelWD KaelWD changed the title fix(VSelect,VCombobox,VAutocomplete): replace onfocusout with onAfterleave fix(VSelect): replace onfocusout with onAfterleave May 3, 2023
@KaelWD KaelWD merged commit 36e75c2 into master May 3, 2023
24 checks passed
@KaelWD KaelWD deleted the fix-17214 branch May 3, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.1.15] Autocomplete tab key is not working on Firefox
2 participants