Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VFileInput): add hideInput prop #17270

Merged

Conversation

Reidemption
Copy link
Contributor

My attempt at adding the hideInput prop back in for Vuetify 3. Please let me know if it requires more changes. :^)

Description

I added a hideInput prop and toggled the styling to display: 'none' if the prop is set to true. I'm sure there are better ways to do this, but this seemed the simplest. I made this change because it was previously an option in v2, but it currently is not in v3.

resolves #17142

Markup:

<template>
  <div class="hello">
    <v-form style="width: 50%; margin: 0 auto">
      <v-file-input
        class="fileInput"
        label="Select a image"
        accept="image/*"
        :hide-input="true"
        :clearable="false"
        :counter="false"
      />
    </v-form>
  </div>
</template>

<script>
  export default {
    name: 'HelloWorld',
  }
</script>

<!-- Add "scoped" attribute to limit CSS to this component only -->
<style scoped lang="scss">
  .hello {
    display: flex;
    justify-content: center;
    align-items: center;
    height: 100%;
  }
  .fileInput {
    width: 100%;
  }
</style>

@KaelWD KaelWD force-pushed the master branch 12 times, most recently from 7c417af to 070e2aa Compare May 24, 2023 13:23
@johnleider johnleider changed the base branch from master to dev July 5, 2023 17:30
@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VFileInput labels Aug 14, 2023
@MajesticPotatoe MajesticPotatoe changed the title fix(VInputFile): add hideInput prop fix(VFileInput): add hideInput prop Aug 14, 2023
@landynfrancis
Copy link

Does anyone have an idea when this PR will be merged in? I need the Hide Input prop for my VFileInput.

@yuwu9145 yuwu9145 self-assigned this Dec 27, 2023
@yuwu9145 yuwu9145 added the S: has merge conflicts The pending Pull Request has merge conflicts label Dec 28, 2023
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of manually applying a style, use a class and then "display: none" in VFileInput.sass.

@landynfrancis
Copy link

Hey all, any idea when this will get merged in? Been looking forward to this change for a little bit now.

@johnleider
Copy link
Member

Hey all, any idea when this will get merged in? Been looking forward to this change for a little bit now.

I left feedback for the author.

@landynfrancis
Copy link

@Reidemption

@johnleider johnleider removed the S: has merge conflicts The pending Pull Request has merge conflicts label Apr 15, 2024
@johnleider johnleider added this to the v3.6.0 (Nebula) milestone Apr 15, 2024
@johnleider johnleider merged commit 614262e into vuetifyjs:dev Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VFileInput T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.1.14] <v-file-input :hide-input="true" /> can not hide to input
5 participants